Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple beam objects to instrument. #417

Closed
joelvbernier opened this issue Mar 25, 2022 · 2 comments
Closed

Add multiple beam objects to instrument. #417

joelvbernier opened this issue Mar 25, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed low priority low priority task

Comments

@joelvbernier
Copy link
Member

This is a fairly involved one, but there is strong motivation to get this implemented to

  1. handle the case of multi-energy sources, e.g., an X-ray tube
  2. handle the case of different incoming beam directions

The strategy would be to

  1. modify the instrument config spec and __init__ method to accept multiple beam blocks analogously to how detectors are handled; and
  2. enable additional looping over beams to all of the functions that need it downstream (again, analogously to how detectors are handled).

I would posit that it makes more sense to put the beam-relative loops inside the existing detector loops since there are likely to be fewer beam specifications than detectors. There are some challenges to how we will handle beams with the same propagation vector, but two energies that are close; we will likely need to catch that case and use it to fit a multi-peaked model to Bragg peaks where needed. @saransh13 @psavery -- could use your input on this.

@joelvbernier joelvbernier added enhancement New feature or request help wanted Extra attention is needed high priority move these to the top of the stack labels Mar 25, 2022
@ZackAttack614 ZackAttack614 added low priority low priority task and removed high priority move these to the top of the stack labels Jul 30, 2024
@ZackAttack614
Copy link
Collaborator

This seems like a big lift, and would require a lot of thinking to make it work in a robust way. I've reduced the priority to low for now, we can come back to this in the future.

@psavery
Copy link
Collaborator

psavery commented Sep 30, 2024

This was fixed by #721!

@psavery psavery closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed low priority low priority task
Projects
None yet
Development

No branches or pull requests

4 participants