-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try using libmamba solver for conda packaging #562
Conversation
7aca06d
to
2cf3813
Compare
It is [officially supported by conda](https://www.anaconda.com/blog/conda-is-fast-now), and it is significantly faster. Before this commit, Windows packaging usually takes 1 hour and 15 minutes. Mac packaging usually takes about 45 minutes. Linux usually takes about 35 minutes. We'll see if there are any noticeable differences. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
2c4e82a
to
e495efd
Compare
I got libmamba working for the Linux packaging, and it reduced the time by about half to about 17 minutes! That's a great speedup. However, I haven't figured out yet how to get it working for Windows and Mac. I am setting up the solver to be libmamba, but |
61ee3c3
to
1aae1a0
Compare
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
8e1e6e2
to
48ad592
Compare
It worked in the last commit, let's see if we can simplify it. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
d2174d4
to
8647375
Compare
Well, for Mac and Windows, I had to install libmamba twice, and set it in the environment twice. I'm not sure why, but I've spent an hour or two trying to figure it out and was unable to figure it out. It has something to do with conda build's internal processes, which I do not know much about. I don't have time to continue exploring this, so we will leave it as is. Anyways, it does make the packaging much faster for all operating systems! The packaging is nearly twice as fast for every OS. Windows took 40 minutes instead of 75 minutes. Mac took 18 minutes instead of 45 minutes. And Linux took 15 minutes instead of 35 minutes. This PR is ready to go! We should do something similar for HEXRDGUI. |
This will potentially run significantly faster, as also demonstrated in HEXRD/hexrd#562. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!! LGTM!
It is officially supported by conda, and it is significantly faster.
Before this commit, Windows packaging usually takes 1 hour and 15 minutes. Mac packaging usually takes about 45 minutes. Linux usually takes about 35 minutes.
We'll see if there are any noticeable differences.
Fixes: #556