Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include "roi" in the config if it is not None #579

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Nov 14, 2023

The config is valid without the "roi". If the "roi" is None, we just should not include it at all.

This helps clean up the tree view a little bit in HEXRDGUI, so that there isn't an "roi" present when there is none.

Copy link
Collaborator

@bnmajor bnmajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@psavery psavery requested a review from bnmajor November 14, 2023 22:08
The config is valid without the "roi". If the "roi" is None, we just
should not include it at all.

This helps clean up the tree view a little bit in HEXRDGUI, so that there
isn't an "roi" present when there is none.

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
@psavery psavery merged commit 540768b into master Nov 15, 2023
6 checks passed
@psavery psavery deleted the remove-roi-if-none branch November 15, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants