Refactored two functions #660
Conversation
Code coverage
|
Hello @kevindlewis23! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-07-02 15:31:03 UTC |
| @@ -93,9 +93,9 @@ def cellIndices(edges, points_1d): | |||
| def _fill_connectivity(out, m, n, p): | |||
| i_con = 0 | |||
| for k in range(p): | |||
| extra = k*(n+1)*(m+1) | |||
| T[:, i + 3, j] = sqr2 * R[:, i1, j] * R[:, i2, j] | ||
| T[:, i + 3, j + 3] = ( | ||
| R[:, i1, j1] * R[:, i2, j2] + R[:, i1, j2] * R[:, i2, j1] | ||
| ) |
There was a problem hiding this comment.
Glad you wrote a test for this change!
|
Looks like |
I think we'll need to bump the version: |
|
Hmm... that's a shame. We could upgrade to centos 8, which would increase our glibc version to 2.28. But the problem is that there are still a lot of Linux computers out there that are still on glibc 2.17. It seems a lot of people (such as manylinux2014 python wheel standard) will still be using centos 7 for the time being for maximum compatibility on Linux systems. It might be best to use an archive mirror instead, like it appears some people are doing. |
|
The packaging issue is now fixed in master. Feel free to rebase on master and push here, and it should fix the CI. |
…ion/hexrd into minor-refactoring
Refactor of computeIntersection and vecmvcobmatrix, as well as some small style changes.code fixes. Both tested, one with permanent testcases written