Remove point selection from WPPF #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need to import matplotlib from the code. Now, it expects the background points to have been pre-selected elsewhere, and the background points is the single argument for the `spline` background method. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
They have been used interchangeably with min/max. So make references for code that uses either (for backward compatibility). Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #719 +/- ##
==========================================
+ Coverage 37.34% 37.37% +0.03%
==========================================
Files 134 134
Lines 21737 21730 -7
==========================================
+ Hits 8118 8122 +4
+ Misses 13619 13608 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
saransh13
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to import matplotlib from the code.
Now, it expects the background points to have been pre-selected elsewhere,
and the background points is the single argument for the
splinebackgroundmethod.
Corresponding branch in the GUI: HEXRD/hexrdgui#1728