Add support for multiple x-ray sources #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for multiple x-ray sources to the instrument and powder calibration. This will be the base for all multi-xrs work going forward. Most instruments will not be using multiple x-ray sources, so a concept of an "active beam" is present so that software can assume there is only one beam. Properties like `instr.beam_energy` return the energy of the active beam. Another method was also added to easily switch between beam sources when needed. The `with_xray_source()` context manager can be used to temporarily switch the active beam to another beam, if some calculations that assume only one beam need to be performed with a different active beam. This results in significantly cleaner code than if we had to make all hexrd source code multi-beam aware. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This matches what we are using for 2XRS, and we were told by Saransh that this is more common. So we will make it the default. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
We need to find a good example to test this on. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This appears to be working well... Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
The panels on the instrument get updated regularly during calibration. We need to make sure that the panels in the tth_distortion are identical and also get updated. This adds logic to do so. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This calibrates two powder overlays from separate x-ray sources simultaneously. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #721 +/- ##
==========================================
+ Coverage 37.26% 37.93% +0.66%
==========================================
Files 134 134
Lines 21826 21961 +135
==========================================
+ Hits 8134 8330 +196
+ Misses 13692 13631 -61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for multiple x-ray sources, which may have different beam vectors, energies, and distances.
This also adds support for calibrating to diffraction patterns from multiple x-ray sources, including for powder, Laue, and also structureless.