Use the libmamba solver for packaging #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will potentially run significantly faster, as also demonstrated in HEXRD/hexrd#562. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
|
In the latest commit, the Linux package took 10 minutes (more than twice as fast), but Mac and Windows took close to the same amount of time. I'll try a few more things. |
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
|
In the latest update, Linux ran in 14 minutes (compared to 26), Mac ran in 24 minutes (compared to 43), and Windows ran in 67 minutes (compared to 87). I think the performance improvements are significant! This is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will potentially run significantly faster, as also demonstrated in HEXRD/hexrd#562.
The last merged packaging CI for HEXRDGUI took this long:
We'll see if we get any big speed improvements on the packaging.