Add a variety of fixes and improvements to WPPF #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want them showing up in the spline as 0, since that is not actually a part of the background and can mess up the background... Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Previously, if the user ran WPPF without making "Scale" refinable in the first iteration, the azimuthal integration scale would become very zoomed out (in y) since the WPPF points would often be extremely large. This would be difficult to fix since future refinements did not scale the y-axis down. This commit adds an autoscaling that ignores the WPPF scatter points, and that keeps it zoomed in on the line data. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
The spline method requires picking background points. This was previously being done with pylab in hexrd. However, this is a deprecated module, and it required the use of middle click (which not everyone had access to). It also would make points appear while doing things such as pan/zoom. The new point picker solves all of these issues. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Rietveld can only have one refinement step. Make it clear that is what we are doing by setting it to 1. Before, it would be grayed out, but could be set to something other than 1. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This converts the WPPF table view into a tree view instead, that follows the same patterns as those found in the calibration workflow. As far as I can tell, everything seems to be working properly... Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Brianna Major <brianna.major@taloid.khq.kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a tree view, an undo button, a new picker for spline points, and several other fixes.
Depends on: HEXRD/hexrd#719