Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a variety of fixes and improvements to WPPF #1728

Merged
merged 10 commits into from
Sep 26, 2024
Merged

Add a variety of fixes and improvements to WPPF #1728

merged 10 commits into from
Sep 26, 2024

Commits on Sep 5, 2024

  1. In WPPF, fill masked azimuthal values with nan

    We don't want them showing up in the spline as 0, since that
    is not actually a part of the background and can mess up the
    background...
    
    Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
    psavery committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    2cbc0a6 View commit details
    Browse the repository at this point in the history
  2. Do not rescale from WPPF scatter points

    Previously, if the user ran WPPF without making "Scale" refinable
    in the first iteration, the azimuthal integration scale would become
    very zoomed out (in y) since the WPPF points would often be extremely
    large. This would be difficult to fix since future refinements did
    not scale the y-axis down.
    
    This commit adds an autoscaling that ignores the WPPF scatter points, and
    that keeps it zoomed in on the line data.
    
    Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
    psavery committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f26a3e9 View commit details
    Browse the repository at this point in the history
  3. Add a point picker to use for spline in WPPF

    The spline method requires picking background points. This was previously
    being done with pylab in hexrd. However, this is a deprecated module, and
    it required the use of middle click (which not everyone had access to). It
    also would make points appear while doing things such as pan/zoom.
    
    The new point picker solves all of these issues.
    
    Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
    psavery committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    fc48611 View commit details
    Browse the repository at this point in the history
  4. Set refinement steps to 1 if Rietveld is selected

    Rietveld can only have one refinement step. Make it clear that is
    what we are doing by setting it to 1.
    
    Before, it would be grayed out, but could be set to something other than 1.
    
    Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
    psavery committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    83d7dc8 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Use tree view for WPPF

    This converts the WPPF table view into a tree view instead, that
    follows the same patterns as those found in the calibration workflow.
    
    As far as I can tell, everything seems to be working properly...
    
    Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
    psavery committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    d062917 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. WIP: Undo last run

    Signed-off-by: Brianna Major <brianna.major@taloid.khq.kitware.com>
    Brianna Major committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b0336fd View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Fix a few things with WPPF undo stack

    Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
    psavery committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    27a866b View commit details
    Browse the repository at this point in the history
  2. Fix chebyshev background parameter generation

    Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
    psavery committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9b7d645 View commit details
    Browse the repository at this point in the history
  3. Undo lattice parameter settings too

    Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
    psavery committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    28eadf7 View commit details
    Browse the repository at this point in the history
  4. Fix undo for atomic site information

    Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
    psavery committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    cac118b View commit details
    Browse the repository at this point in the history