Fix matplotlib version to be less than 3.10 #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's some new issue with removing several of our artists starting in matplotlib 3.10 (including overlays, detector borders, the beam marker, and potentially more). It is very common that when `remove()` is called on the artists, that a `NotImplementedError` is raised. Perhaps this is an issue that will get fixed in matplotlib soon. If not, we'll need to figure out an alternative way to remove the artists. But for the release coming up, let's just fix the matplotlib version. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
bnmajor
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some new issue with removing several of our artists starting in matplotlib 3.10 (including overlays, detector borders, the beam marker, and potentially more). It is very common that when
remove()is called on the artists, that aNotImplementedErroris raised.Perhaps this is an issue that will get fixed in matplotlib soon. If not, we'll need to figure out an alternative way to remove the artists.
But for the release coming up, let's just fix the matplotlib version.