Various fixes and improvements #1775
Merged
+323
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old `rectangle` function is deprecated, and `footprint_rectangle` is necessary. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
A sequence is now required in the newer versions of matplotlib... Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
We should not keep the same calibration picks on the overlays if the detectors are changed. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
If any required detectors are missing, we should not auto-set it. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This follows the same pattern we used for the other setters. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
We were accidentally resetting the calibration parameters if the relative constraints were set to None. Don't do that, and just make sure that the instrument constraints are reset... Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
We'll need to add this to the structureless calibration too soon... Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This is needed to work properly with `update_physics_package()` Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
For cylindrical detectors, we need to take into account the radius for calibration flags and parameters. This uses the old, non-lmfit style for defining calibration flags and parameters. We will be able to eliminate all of this when we upgrade the HEDM calibration to use the new lmfit calibration style... But for now, we need to maintain this. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Disable the value and the checkbox for the Y value of IP4 when TARDIS engineering constraints are applied. We cannot vary or modify the value of an lmfit parameter whose value is computed via an expression in lmfit. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
If "Show picks from all x-ray sources" is not checked, picks for the non-selected x-ray source are now grayed out and not editable. This is much better than before, where an error would simply occur if users tried to edit non-selected x-ray source picks (or worse, in structureless calibration, the point would be added inadvertently to the wrong source). Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
saransh13
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.