Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds mrec and interp combinators to itreeTauTheory #1263

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

xdrr
Copy link

@xdrr xdrr commented Jun 28, 2024

This change introduces the mrec and interp combinators to itreeTauTheory.
The mrec combinator is used extensively in the Pancake itree semantics.

@xdrr xdrr changed the title Adds mrec and interp combinators Adds mrec and interp combinators to itreeTauTheory Jun 28, 2024
@mn200
Copy link
Member

mn200 commented Jul 1, 2024

It would be good if you could add a comment above the new material explaining the new constants and how they might be used. If you want to go wild, it would be nice to have a description of the itree theories in the DESCRIPTION manual...

@Plisp
Copy link
Contributor

Plisp commented Jul 2, 2024

don't forget the proofs about their properties too!

@mn200
Copy link
Member

mn200 commented Jul 2, 2024

Your PR is failing our source code tests. (Locally, you can replicate this by doing a build -t.)

In particular, material under src/ can't use Unicode characters (except for the 'magic' quotes “”‘’ and the lambda).

@xdrr xdrr marked this pull request as draft July 5, 2024 06:29
@binghe
Copy link
Member

binghe commented Jul 11, 2024

It seems that this PR also needs an approval to start the CI tests, as the contributor is new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants