Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build release action no longer working #645

Closed
EdwardMoyse opened this issue Mar 20, 2024 · 6 comments
Closed

Build release action no longer working #645

EdwardMoyse opened this issue Mar 20, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@EdwardMoyse
Copy link
Collaborator

Successfully replaced in file /home/runner/work/phoenix/phoenix/docs/api-docs/index.html
file:///home/runner/work/phoenix/phoenix/node_modules/prettier/index.mjs:22061
        throw new UndefinedParserError(
              ^

UndefinedParserError: No parser could be inferred for file "/home/runner/work/phoenix/phoenix/yarn.lock".
    at normalizeFormatOptions (file:///home/runner/work/phoenix/phoenix/node_modules/prettier/index.mjs:22061:15)
    at formatWithCursor (file:///home/runner/work/phoenix/phoenix/node_modules/prettier/index.mjs:22794:52)
    at file:///home/runner/work/phoenix/phoenix/node_modules/prettier/index.mjs:24189:12
    at async Module.format2 (file:///home/runner/work/phoenix/phoenix/node_modules/prettier/index.mjs:24194:25)

Node.js v18.19.1

I have not yet been able to reproduce this locally.

https://github.com/HSF/phoenix/actions/runs/8338646866

@EdwardMoyse EdwardMoyse added the bug Something isn't working label Mar 20, 2024
@EdwardMoyse EdwardMoyse self-assigned this Mar 22, 2024
@EdwardMoyse
Copy link
Collaborator Author

Fixed.

@EdwardMoyse EdwardMoyse reopened this Mar 22, 2024
@EdwardMoyse
Copy link
Collaborator Author

Argh. Except that it seems like it hasn't pushed to npm:
https://www.npmjs.com/package/phoenix-event-display

But this might be because of my previous efforts locally (see #649 ):

From the log

lerna info current version 2.15.0
lerna notice Current HEAD is already released, skipping change detection.
lerna success No changed packages to publish

@EdwardMoyse
Copy link
Collaborator Author

Still not working. See this in the log:

Error: Could not find the '@angular-devkit/ng-packagr:build' builder's node package.
lerna ERR! lifecycle "prepublishOnly" errored in "phoenix-ui-components", exiting 1

Presumably related to: #644

@EdwardMoyse
Copy link
Collaborator Author

I do not see this error locally - but locally it seems to stop just before this i.e. with

Successfully replaced in file /Users/emoyse/LocalDocuments/phoenix/docs/api-docs/index.html
lerna info git Pushing tags...
lerna info publish Publishing packages to npm...
lerna success All packages have already been published.

What I do not understand is why the git action is doing more than this?

- name: Release
run: yarn release:${{ inputs.release_type }} --yes
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

This seems to be exactly what is done locally.

Also, why does npm publish not work here, despite lerna saying it has?

lerna info publish Publishing packages to npm...

@9inpachi If you have any time to look at this, I would be very grateful. I urgently need to publish a new version of PhoenixATLAS and I'm running out of ideas here.

@EdwardMoyse
Copy link
Collaborator Author

Ah. I suspect part of the issue might be related to moving to angular 17... I think angular.json might need updating.

@EdwardMoyse
Copy link
Collaborator Author

Possibly fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant