Allowed to specify "no-cache" for file loading #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is actually useful in case of automatic file reload when cycling on live events. Without it, new events are not loaded as the cache enters the game. This included extending the file-loader API to allow any options to be passed when loading a file.
sponce
force-pushed
the
sponce_nocache
branch
from
83ddb63 to
cc338ef
Compare
|
Sorry for the very long delay in accepting this @sponce |
|
No problem ! There was absolutely no hurry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually useful in case of automatic file reload when cycling on live events. Without it, new events are not loaded as the cache enters the game.
This included extending the file-loader API to allow any options to be passed when loading a file.
It allows the following syntax in json files uses by the loader component :
[ {"name":"Live events.json", "url":"https:\/\/.../liveEvents.json.zip", "nocache":"true"}, {"name":"2023/FirstCollisions2023.json", "url":"\/assets\/files\/lhcb\/FirstCollisions2023.json.zip"}, ... ]