Better Regex e-mail #186
Merged
Better Regex e-mail #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaHaWTH
requested changes
Jul 22, 2024
src/main/java/fr/xephi/authme/settings/properties/RestrictionSettings.java
Show resolved
Hide resolved
HaHaWTH
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Regex e-mail doesn't account for people in other countries (for example, in my country
@seznam.czis a popular e-mail!) or custom e-mails at that (@luketeam5.xyz)I think it's better to allow any valid-looking e-mail addresses as default rather than restrict to popular mail providers only.
If someone wants to restrict to g-mail, outlook, ... they can do so manually, that's what the config is for after all.
But should allow all e-mail out of the box.