From a6af141fc7f1f87dc1ae09abf7556b5f9849beb5 Mon Sep 17 00:00:00 2001 From: joonhan Date: Fri, 11 Oct 2024 19:13:50 +0900 Subject: [PATCH] =?UTF-8?q?remove:=20=EC=B1=8C=EB=A6=B0=EC=A7=80=20?= =?UTF-8?q?=EA=B0=9C=EB=B3=84=20=EC=A0=95=EB=B3=B4(1=ED=9A=8C=20=EC=8B=A4?= =?UTF-8?q?=ED=8C=A8=EB=8B=B9=20=EB=B2=8C=EA=B8=88,=20=EC=B1=8C=EB=A6=B0?= =?UTF-8?q?=EC=A7=80=20=EB=B2=8C=EA=B8=88=20=EC=B4=9D=ED=95=A9,=20?= =?UTF-8?q?=EC=B1=8C=EB=A6=B0=EC=A7=80=20=EC=A7=84=ED=96=89=20=EA=B8=B0?= =?UTF-8?q?=EA=B0=84,=20=EC=B1=8C=EB=A6=B0=EC=A7=80=20=EC=B0=B8=EC=97=AC?= =?UTF-8?q?=20=EC=9A=94=EC=9D=BC)=20=EC=A1=B0=ED=9A=8C=20=EC=84=9C?= =?UTF-8?q?=EB=B9=84=EC=8A=A4=20=EC=82=AD=EC=A0=9C=20#273?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../application/ChallengeDetailsService.java | 41 ++----------------- 1 file changed, 3 insertions(+), 38 deletions(-) diff --git a/src/main/java/com/habitpay/habitpay/domain/challenge/application/ChallengeDetailsService.java b/src/main/java/com/habitpay/habitpay/domain/challenge/application/ChallengeDetailsService.java index 68739e9..6a7a64b 100644 --- a/src/main/java/com/habitpay/habitpay/domain/challenge/application/ChallengeDetailsService.java +++ b/src/main/java/com/habitpay/habitpay/domain/challenge/application/ChallengeDetailsService.java @@ -1,7 +1,7 @@ package com.habitpay.habitpay.domain.challenge.application; import com.habitpay.habitpay.domain.challenge.domain.Challenge; -import com.habitpay.habitpay.domain.challenge.dto.*; +import com.habitpay.habitpay.domain.challenge.dto.ChallengeDetailsResponse; import com.habitpay.habitpay.domain.challengeenrollment.dao.ChallengeEnrollmentRepository; import com.habitpay.habitpay.domain.challengeenrollment.domain.ChallengeEnrollment; import com.habitpay.habitpay.domain.member.domain.Member; @@ -36,6 +36,7 @@ public SuccessResponse getChallengeDetails(Long challe }) .toList(); + // TODO: Challenge 엔티티에 totalAbsenceFee 컬럼 추가 후 Response 생성 시 전달하는 매개변수도 함께 변경 부탁드립니다. (from. joonhan) int totalAbsenceFee = sumAllFeesOfChallenge(challenge); return SuccessResponse.of( @@ -49,25 +50,7 @@ public SuccessResponse getChallengeDetails(Long challe ); } - public SuccessResponse getChallengeFeePerAbsence(Long challengeId) { - Challenge challenge = challengeSearchService.getChallengeById(challengeId); - - return SuccessResponse.of( - SuccessCode.NO_MESSAGE, - ChallengeFeePerAbsenceResponse.from(challenge) - ); - } - - public SuccessResponse getChallengeTotalAbsenceFee(Long challengeId) { - Challenge challenge = challengeSearchService.getChallengeById(challengeId); - int totalAbsenceFee = sumAllFeesOfChallenge(challenge); - - return SuccessResponse.of( - SuccessCode.NO_MESSAGE, - ChallengeTotalAbsenceFeeResponse.from(totalAbsenceFee) - ); - } - + // TODO: Challenge 엔티티에 totalAbsenceFee 컬럼 추가 후 아래의 함수 삭제 부탁드립니다. (from. joonhan) private int sumAllFeesOfChallenge(Challenge challenge) { List enrollmentList = challengeEnrollmentRepository.findAllByChallenge(challenge); return enrollmentList @@ -75,22 +58,4 @@ private int sumAllFeesOfChallenge(Challenge challenge) { .mapToInt(enrollment -> enrollment.getParticipationStat().getTotalFee()) .sum(); } - - public SuccessResponse getChallengeDates(Long challengeId) { - Challenge challenge = challengeSearchService.getChallengeById(challengeId); - - return SuccessResponse.of( - SuccessCode.NO_MESSAGE, - ChallengeDatesResponse.from(challenge) - ); - } - - public SuccessResponse getChallengeParticipatingDays(Long challengeId) { - Challenge challenge = challengeSearchService.getChallengeById(challengeId); - - return SuccessResponse.of( - SuccessCode.NO_MESSAGE, - ChallengeParticipatingDaysResponse.from(challenge) - ); - } }