Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example in README #30

Open
aquynh opened this issue Nov 15, 2021 · 2 comments
Open

update example in README #30

aquynh opened this issue Nov 15, 2021 · 2 comments
Labels
delight Nice to haves!

Comments

@aquynh
Copy link
Contributor

aquynh commented Nov 15, 2021

for now README mentions this command:

$ stack run -- INPUT

but when replacing INPUT with a filename, it does not work:

$ stack run --  compiler/test-data/untyped/add0/add0.plc
clang: error: no such file or directory: './rts/rts.c'
@mbg
Copy link
Contributor

mbg commented Nov 15, 2021

Indeed. The compiler cannot easily know where the rts.c file is located relative to the location of the executable / working directory, so it defaults to ./rts/rts.c relative to the current working directory if no --rts is specified. If you are running the compiler from a directory where ./rts/rts.c doesn't exist, then you will see this error. Either navigate to a directory for which this assumption holds (i.e. compiler) or specify the path with either --rts ./compiler/rts/rts.c.

@aquynh
Copy link
Contributor Author

aquynh commented Nov 15, 2021

yes, README should be updated to either explain the path issue or just remove that instruction.

i think it is good to provide some sample plc files (like in samples/ dir) and use them for demo in README.

@kk-hainq kk-hainq added the delight Nice to haves! label May 9, 2022
@mbg mbg removed their assignment Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delight Nice to haves!
Projects
None yet
Development

No branches or pull requests

3 participants