Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up deployment target #586

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Bump up deployment target #586

wants to merge 2 commits into from

Conversation

anushkasankaran
Copy link
Contributor

Fixes #585

  • Deployment target increase from iOS 14.0 to iOS 17.0.
  • Re-added url-image package to fix missing package dependencies.

@AydanPirani
Copy link

@anushkasankaran hmm, is build supposed to be failing?

@lasyaneti
Copy link
Contributor

Does local build work? Error looks like an architecture issue but PR diff doesn't touch anything related to that.

@anushkasankaran
Copy link
Contributor Author

Local build was working fine. It was kind of buggy though and I did something irrelevant to most of the build errors and it got rid of all of them.

@s0phialiu
Copy link
Contributor

warning: None of the architectures in ARCHS (x86_64) are valid. Consider setting ARCHS to $(ARCHS_STANDARD) or updating it to include at least one value from VALID_ARCHS (arm64, arm64e, armv7, armv7s). (in target 'URLImage' from project 'URLImage')

  1. Can you go to Project Settings in Xcode, go to build settings, and see if setting Architectures to $(ARCHS_STANDARD) does anything?
  2. Can you try making a dummy PR with the non-bumped up version and see if there's still a build error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasyaneti lasyaneti Awaiting requested review from lasyaneti lasyaneti is a code owner

@s0phialiu s0phialiu Awaiting requested review from s0phialiu s0phialiu is a code owner

@AydanPirani AydanPirani Awaiting requested review from AydanPirani AydanPirani is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump up deployment target
4 participants
@anushkasankaran @AydanPirani @lasyaneti @s0phialiu