Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov config #4816

Merged
merged 1 commit into from
May 23, 2024
Merged

Update codecov config #4816

merged 1 commit into from
May 23, 2024

Conversation

martijnrusschen
Copy link
Member

It seems the previous config was still using a tokenless config

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (ff3607c) to head (0e9ef69).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4816   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files          28       28           
  Lines        2882     2882           
  Branches     1245     1245           
=======================================
  Hits         2768     2768           
  Misses        114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martijnrusschen
Copy link
Member Author

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

Check the status or cancel PullRequest code review here - or - cancel by adding [!pr] to the title of the pull request.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 2
- 1

100% GitHubActions (tests)

Type of change

Minor Update - These changes appear to be a minor update to existing functionality and features.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading the token as an environment variable instead of a step input parameter looks good to me. No issues stand out here, and both approaches seem valid per https://github.com/codecov/codecov-action.

Image of Mark M Mark M


Reviewed with ❤️ by PullRequest

@martijnrusschen
Copy link
Member Author

For some reason the previous config didn't see the token passed in and was using the tokenless upload function. Very strange both seem to be supported, but I can see in the CI run that it's using the token now.

@martijnrusschen martijnrusschen merged commit 2d66a92 into main May 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant