-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot show stars/1 #22
Comments
@zniazi Can you please raise a pull request with the appropriate commits? |
Yes, will submit it later Sent from my iPhone
|
@zniazi what does stars/1 mean? we are currently only referencing the stars resource by the label. what is 1 in this context? |
Oh I see, I meant to reference them by their id. I feel like developers are used to that. Especially as these stars have many associations to other objects. Sent from my iPhone
|
interesting - i think the record id is a dangerous thing to correlate to the star resource because the id could be something different depending on the database used and it is not nessecarily the identifying element of a given resource. perhaps with constellations it is different but i think stars should definitely be referenced by their label... maybe. |
In some senses the label is the id here. We need to add unique key to the label in the database.
|
right, the label is the id - that's what i was going for. the uniqueness On Wed, Nov 12, 2014 at 1:41 PM, Surendran Mahendran <
|
Sounds good to me. The label if unique can serve as the id. One thing to On Wed, Nov 12, 2014 at 1:47 PM, nichol alexander notifications@github.com
|
cool! On Wed, Nov 12, 2014 at 2:09 PM, Zak Niazi notifications@github.com wrote:
|
I pushed code near the end of Saturday that fixes this and shows /stars/1 or constellations/1 etc. Please check that push.
The text was updated successfully, but these errors were encountered: