Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrushStoreWindow: delay drawing until all brushes are loaded #647

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

dsizzle
Copy link
Collaborator

@dsizzle dsizzle commented Nov 7, 2023

Fixes #602

@humdingerb
Copy link
Member

The effect was barely visible on my 9 year old machine... but it's gone with this change. It's still there in the brush preview in the canvas window's status bar though.

@dsizzle
Copy link
Collaborator Author

dsizzle commented Nov 8, 2023

Really? I have never seen that happen in the status bar. You see the status bar preview cycle through all the brushes?

@humdingerb
Copy link
Member

I never noticed it before, but since this PR fixed the preview in the Brushes window, I had a look. It's identical to the what happened in the Brushes preview. Last only 1/10s or something. I had to double the number of my saved brushes to now 12. It helps to mix round and rect brushes to see the changes.

@dsizzle
Copy link
Collaborator Author

dsizzle commented Nov 8, 2023

ok, I had to try many times to get it to happen, so I'm not super worried about it. I'm going to go ahead and merge this change for now.

@dsizzle dsizzle merged commit a77b587 into HaikuArchives:master Nov 8, 2023
2 checks passed
@dsizzle dsizzle deleted the brush-window-wait branch November 8, 2023 18:47
@dsizzle
Copy link
Collaborator Author

dsizzle commented Nov 8, 2023

of course as soon as I did, now I see it every time... sigh...

@humdingerb
Copy link
Member

FWIW, I didn't find it annoying. It's like when you turn on the ignition and the speedo/rpm meter resets and their hands quickly move to max and back to zero. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Don't update Brush window until all brushes are loaded
2 participants