Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic CMake syntax support. #102

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

OscarL
Copy link
Contributor

@OscarL OscarL commented Oct 5, 2024

No description provided.

@OscarL
Copy link
Contributor Author

OscarL commented Oct 5, 2024

C.I. builds failed due to the lack of beta4 repositories from where to get the required libpcre_devel.

@Begasus
Copy link

Begasus commented Oct 5, 2024

+1 from me

@korli
Copy link
Contributor

korli commented Oct 6, 2024

Could you please add some header comment to Languages/Sources/CMake_Language.cpp (copyright, etc..) ?

@OscarL
Copy link
Contributor Author

OscarL commented Oct 22, 2024

Could you please add some header comment to Languages/Sources/CMake_Language.cpp (copyright, etc..) ?

@korli, let me know if the change I've made are acceptable, or further changes are required. Thanks.

@korli
Copy link
Contributor

korli commented Oct 24, 2024

@korli, let me know if the change I've made are acceptable, or further changes are required. Thanks.

It looks good to me.

@korli korli merged commit d7834bf into HaikuArchives:master Oct 25, 2024
0 of 2 checks passed
@OscarL OscarL deleted the cmake-syntax branch October 25, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants