Support opening files with file:line:col style arguments.
#91
Conversation
OscarL
changed the title
lpe file:line:collpe file:line:col and /bin/open file:line:col.
OscarL
force-pushed
the
issue-68
branch
2 times, most recently
from
4a2f0a3 to
20c13a9
Compare
|
Sorry to bother you @korli, but maybe you can take a look at this and my two other pending PRs for Pe, and see if they can be merged (or tell me what I should improve)? |
|
@OscarL recommended is strtol() instead of atoi(). Error returned by strtol() should also be checked and handled. |
OscarL
changed the title
lpe file:line:col and /bin/open file:line:col.file:line:col style arguments.
(support for ":col" is what's new) lpe uses a custom message, while `/bin/open file:line:col` (what Terminal uses when "hyperlinking" to filenames, for example) uses a B_REFS_RECEIVED message. We support both. Fixes HaikuArchives#68.
|
Tried to follow @korli's leads (btw, korli, anything you can do about the broken workflows/CI?). @waddlesplash, anything fundamentally wrong with this that prevents merging? (just trying to keep my list of custom patches to a minumum) |
some follow-up comments from me. |
|
Understood. Not a big deal, at least after I went and disabled email notifications about failing workflows on Github. May be reasonable to consider disabling such CI's till they work properly again? |
Co-authored-by: Jérôme Duval <jerome.duval@gmail.com>
I disabled on this repository, but it's possible that it is still enabled on forks. |
Fixes #68.