Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable cinematic "fake widescreen" bars by default #47

Closed
Tracked by #44
BinToss opened this issue Oct 22, 2020 · 8 comments
Closed
Tracked by #44

Disable cinematic "fake widescreen" bars by default #47

BinToss opened this issue Oct 22, 2020 · 8 comments

Comments

@BinToss
Copy link
Member

BinToss commented Oct 22, 2020 •
edited
Loading

Part of #44

These are stupid unless the video source is 4:3. Their intended use is to crop a scene from 4:3 to 16:9 or wider.
We don't need that in this age dominated by wide, extra-wide, and ultra-wide displays.
I don't think it's necessary even in 4:3.

Spiel done.

https://github.com/yumiris/SPV3/blob/376079c1e254c2169f61189342152e34992cccf0/src/Configuration.Loader.cs#L41

https://github.com/yumiris/HXE/blob/f00389e018aac9db4250843f9f29c2d5e9f042e4/src/Kernel.cs#L1034
@BinToss BinToss mentioned this issue Nov 1, 2020
Closed
MirisWisdom added a commit that referenced this issue Nov 1, 2020
@MirisWisdom
Decrease Default Settings
8024015 
Resolves #50 and #47 on GitHub, resolves #51 PR on GitHub.
@MirisWisdom
Copy link

Resolved in 8024015.

@MirisWisdom
Copy link

Got scammed, the aforementioned commit doesn't change the default value grr

@MirisWisdom MirisWisdom reopened this Nov 1, 2020
@BinToss
Copy link
Member Author

BinToss commented Nov 2, 2020

It doesn't? God f...

BinToss referenced this issue in BinToss/HCE Nov 2, 2020
@BinToss
Disable Cinematic Black Bars by default
a6fc434
@MirisWisdom
Copy link

Resolved in f7f8aa0.

@MirisWisdom
Copy link

MirisWisdom commented Nov 2, 2020 •
edited
Loading

Got scammed again, _cinematic got renamed to _cinemabars without updating the references elsewhere.

https://github.com/yumiris/SPV3/blob/f7f8aa0aaf7843ca63ed0c4e93ca3165ada8f514/src/Configuration.Loader.cs#L41
The following needs to reference _cinemabars:
https://github.com/yumiris/SPV3/blob/f7f8aa0aaf7843ca63ed0c4e93ca3165ada8f514/src/Configuration.Loader.cs#L216-L225

@MirisWisdom MirisWisdom reopened this Nov 2, 2020
@BinToss
Copy link
Member Author

BinToss commented Nov 3, 2020 via email

@BinToss
Copy link
Member Author

BinToss commented Nov 4, 2020 •
edited
Loading

hold up...
BinToss@145bc3e
I had already fixed it. Maybe I forgot to let you know I force-pushed.

@MirisWisdom
Copy link

Resolved in 3cc3793.

MirisWisdom added a commit that referenced this issue Nov 5, 2020
@MirisWisdom
Decrease Default Settings
f009cae 
Resolves #50 and #47 on GitHub, resolves #51 PR on GitHub.
@BinToss BinToss mentioned this issue Nov 7, 2020
Open
25 tasks
MirisWisdom pushed a commit that referenced this issue Feb 6, 2021
@SnowyMouse
Merge pull request #47 from JerryBrick/update_readme
88d5823 
Update spectate commands in readme file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BinToss @MirisWisdom