Changes to allow zero values until cloud data catches up, etc. changed rounding to 3 for Watts for low readings #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stopped returning "unknown" value for sensor where the return from the API is zero value of usage, i.e. running of solar and all entries are valid zero's, also helps with the delay in getting gas readings.
Changes Cost sensor state class to TOTAL to remove HA warning about monetary value
added int check also
Corrected for adding costs up now not total increasing, my bad
Updated to fix cost to be latest
Tested changes, allow for zero returns for consumption, round to 3 places instead of two for Watts, make cost total and not increasing for HA and only get latest cost
|
Please consider these changes |
Trap error if valid cost data not returned
return zero if expection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to allow zero values until cloud data catches up, etc. changed rounding to 3 for Watts for low readings, changed cost to TOTAL in HA instead of TOTOALINCREASING and handle only getting the latest cost.
How Has This Been Tested?
Ran the code for last 2 days and works as expected.
Types of changes