Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI freeze in case of timed out system command #3396

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix UI freeze in case of timed out system command #3396

merged 1 commit into from
Jan 18, 2024

Conversation

PHPirates
Copy link
Collaborator

Fix #3302

Summary of additions and changes

  • Not sure if this was the root cause of the freeze, but waiting for a timed out command doesn't seem sensible to me
  • Cache available pdf viewers to improve startup performance

How to test this pull request

Not sure

@PHPirates PHPirates added this to the Next milestone Jan 15, 2024
@PHPirates PHPirates changed the title Don't wait for stdout output of a command that has timed out Fix UI freeze in case of timed out system command Jan 15, 2024
@PHPirates PHPirates merged commit 714c5e1 into master Jan 18, 2024
9 checks passed
@PHPirates PHPirates deleted the run-command-freeze branch January 18, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HannahSchellekens HannahSchellekens Awaiting requested review from HannahSchellekens

@stenwessel stenwessel Awaiting requested review from stenwessel

@slideclimb slideclimb Awaiting requested review from slideclimb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.4
Development

Successfully merging this pull request may close these issues.

Freeze for 40 seconds
1 participant
@PHPirates