Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CCM Detector Geometry #79

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Conversation

dnewmark99
Copy link
Collaborator

Using CAD model for detector dimensions (Edward's simulation is ~10% too small in radius for the active LAr volume)

Copy link
Collaborator

@austinschneider austinschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I just suggested a few minor comments that could be added, etc.

resources/Detectors/densities/CCM/CCM-v2.dat Outdated Show resolved Hide resolved
resources/Detectors/densities/CCM/CCM-v2.dat Outdated Show resolved Hide resolved
resources/Detectors/densities/CCM/CCM-v2.dat Show resolved Hide resolved
resources/Detectors/densities/CCM/CCM-v2.dat Show resolved Hide resolved
dnewmark99 and others added 4 commits August 30, 2024 11:36
Co-authored-by: Austin Schneider <hogenshpogen@gmail.com>
Co-authored-by: Austin Schneider <hogenshpogen@gmail.com>
Co-authored-by: Austin Schneider <hogenshpogen@gmail.com>
Co-authored-by: Austin Schneider <hogenshpogen@gmail.com>
@austinschneider austinschneider merged commit 56df7ce into main Aug 30, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants