Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a posting has an offer proposal that has been accepted, it should be excluded from search results #78

Open
brozeph opened this issue Jul 20, 2015 · 2 comments
Open

When a posting has an offer proposal that has been accepted, it should be excluded from search results #78

brozeph opened this issue Jul 20, 2015 · 2 comments
Assignees
@that1guy
Labels
enhancement

Comments

@brozeph
Copy link
Contributor

brozeph commented Jul 20, 2015

Today, status of a posting transaction is stored in the transactions collection and there are three possible values:

  • pending
  • completed
  • expired

When the transaction status is set to pending or completed, the posting for which the transaction applies should no longer show up in search results (i.e. should be removed from the ES index).
brozeph added a commit that referenced this issue Jul 23, 2015
@brozeph
fix for #78 - when a posting transaction has been created, remove it …
a8ab8ef 
…from search
brozeph added a commit that referenced this issue Jul 23, 2015
@brozeph
Merge pull request #79 from HashtagSell/remove-postings-from-search
4ca0be9 
fix for #78 - when a posting transaction has been created, remove it …
@brozeph
Copy link
Contributor Author

brozeph commented Jul 23, 2015

All set on this - assigning to @that1guy for additional comments and verification

@that1guy
Copy link
Member

Issue described in #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@that1guy that1guy

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brozeph @that1guy