Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction creation not only removes item from search engine, but all the sellers MyPosts #90

Open
that1guy opened this issue Sep 12, 2015 · 2 comments
Assignees

Comments

@that1guy
Copy link
Member

Hi Josh,

https://github.com/HashtagSell/posting-api/blob/develop/lib/data/postings.js#L618

As it stands now, after a buyer and seller have agreed to meet, and a transaction ID has been created, the item will no longer appear in the search, as expected. However, by removing the item from ES entirely the posting will no longer appear in the seller's My Posts and the Buyer's Watchlist.

Seems we need to "flag" the item as pending and not remove from ES completely. I plan on taking a look at doing this later tonight, but for now I going to push past this.

Thanks for taking a look if you beat me to it.

  • Brad
@that1guy
Copy link
Member Author

Devin and I have discussed this. We believe the item needs to stay in inventory until the review process has confirmed the item has been sold. we need to remove item from ES index after the buyer or seller have confirmed they have exchanged the item.

brozeph added a commit that referenced this issue Sep 23, 2015
brozeph added a commit that referenced this issue Sep 23, 2015
… is updated to have a value of isExchanged === true as well
@brozeph brozeph mentioned this issue Sep 23, 2015
@brozeph
Copy link
Contributor

brozeph commented Sep 23, 2015

Assigning to @that1guy for verification

@brozeph brozeph assigned that1guy and unassigned brozeph Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants