[don't merge] Check compilation server without hxb #11529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/compiler/compilationCache.ml
|
Should we allow this through a define (possibly a "hidden" one) in 5.0 (including previews) for projects where in memory cache was never a problem? For such projects (haxe-formatter for example) hxb overhead can very annoying, with the situation where almost no modules gets invalidated being common and timing goes from 20~40ms to 100ms (latest hxb optimizations means hxb cache is usually slightly faster even on those projects when we start to invalidate modules, but for projects using diagnostics we go back to previously mentioned cases very often). |
|
Makes sense to me, and we should also run at least the server tests like that. |
|
Not needed anymore since #11668 got merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this just so I don't forget about the branch. All this does is disable the hxb-cache to test if the memory-cache still works. I want to make sure that we keep this branch updated do that we don't run into any surprises.