-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macro] apply @:native for extern enum #11636
Conversation
Making this conditional seems strange if the real filters don't do the same. What's the rationale here? |
I'm actually having doubts too. Rationale is that I want the same to happen with macro context, but it's a bit more involved than I first thought because macro context does have both externs for current targets and eval externs... Edit: |
Well.. technically "target externs" should not be loaded in macro context, but I can still see some problematic edge cases. I don't see any with only doing this for |
So what exactly breaks if we just apply this to everything? |
#11481 does |
Ah, I completely forgot about that. In that case I think this change is fine, though it makes me wonder if a variant of #11481 with enum abstracts could exist. |
Turning into a draft while adding a test because it's not working properly for some reason atm 🤔 Edit: right, it's enum abstract, not enum... |
Closes #11631
See also 944d4fd / #11481