Don't populate cache from legacy diagnostics #11696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kLabz
force-pushed
the
dont_populate_cache_from_legacy_diagnostics
branch
from
f0ee319
to
892901b
Compare
|
Very happy to see that |
|
Sadly it also means that until vshaxe gets updated, in practice it'll always be set to |
Because they use display API that breaks the cache
Legacy diagnostics = false, json rpc diagnostics = true
kLabz
force-pushed
the
dont_populate_cache_from_legacy_diagnostics
branch
from
892901b
to
303bb38
Compare
kLabz
added a commit
that referenced
this pull request
Jul 18, 2024
kLabz
added a commit
that referenced
this pull request
Jul 18, 2024
kLabz
added a commit
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11695
Note that vshaxe is still using legacy diagnostics, will need to update it to json RPC diagnostics.