Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Metal.multitask.mt_end_model, line 114. #177

Closed
kexiao17 opened this issue Apr 29, 2019 · 2 comments
Closed

Bug in Metal.multitask.mt_end_model, line 114. #177

kexiao17 opened this issue Apr 29, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@kexiao17
Copy link

variable output_dim is used without being defined, the only definition of output_dim in this function is at line 101 inside another if statement.

@bhancock8 bhancock8 added the bug Something isn't working label Sep 4, 2019
@bhancock8
Copy link
Contributor

Ah, you're right! Thanks for bringing this to our attention. With the release of v0.9 of Snorkel (https://github.com/snorkel-team/snorkel), we merged all the best features of MeTaL back into the main repository, including the multi-task end model (and many other major improvements; see https://www.snorkel.org/hello-world-v-0-9/ for details). Snorkel MeTaL is now in maintenance mode, but Snorkel proper is under active development with more support than ever. Take a look at the new MultitaskClassifier in Snorkel (tutorial here: https://www.snorkel.org/use-cases/multitask-tutorial) and let us know if you have any issues!

@bhancock8
Copy link
Contributor

This should also be fixed now in MeTaL with the merge of PR #211.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants