450 dropdown search improvements #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
j-leidy
commented
Jul 13, 2023
•
j-leidy
commented
- Searchbar has been moved out of valueItem (Where the value items are populated)
- Searchbar is now style-able, ref-able, prop-able (Check how I did the style-able, ref-able, prop-able please.. just want to make sure its right)
- In order to overwrite the value items that get populated in valueItem I created a prop for the dropdown named showSelectedValues. If true, we show them, if false the placeholder remains. ---> I think this makes this PR cover Dropdown | Add ability for placeholder to persist after values are selected #449 as well
- Searchbar is only visible on focus and its value, visibly and statefully, persists focused or not.
…own-search-improvements
…input out of valueitem Headstorm#440
…d to not show selected items re Headstorm#450
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1ddade3:
|
…input component to merge refs This allows us to have the input and the container for the input ref-able re Headstorm#450
… allow mergeref in dropdown re Headstorm#450
aVileBroker
suggested changes
Jul 13, 2023
aVileBroker
suggested changes
Jul 13, 2023
…are easier to understand re Headstorm#450
…ate in Dropdown ^^ dashboard.tsx should be dropdown.tsx re Headstorm#450
aVileBroker
approved these changes
Jul 14, 2023
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.