Clarification Needed on TODO: Proxy Method for SettingsValues in Settings class

[Bkep-Team]

Hi Team,

We came across the TODO comment in the getCurrent method regarding removing the method and adding a proxy method to SettingsValues under Settings.java class. Could someone clarify what this TODO entails?

Specifically:

1. What is the intended functionality of the proposed proxy method?
2. Are there any existing requirements or guidelines we should follow when implementing this?
3. Could someone provide examples or best practices for how to effectively apply this change?
4. We have also noticed that in some instances, getCurrent returns a null value, which causes mColors to be null. Is there any way to ensure that getCurrent does not return null?

Your insights would be greatly appreciated!

Thanks!

[Helium314]

It was added in this commit: LineageOS/android_packages_inputmethods_LatinIME@ff0735a so you will need to try your luck contacting the original author.
(in general there a tons of ancient TODOs back from AOSP keyboard where the meaning is not clear to me)

[Bkep-Team]

Thank you for the details and the commit reference. We’ll look into contacting the original author if possible, though we realize it may be challenging given the age of the code and the unclear context of the original TODO.

We also noticed that while the getCurrent() method exists in the Settings.java class in the AOSP repo, calling this function to retrieve mColors seems to be causing a NullPointerException. It appears that the AOSP keyboard doesn’t include additional properties like mColors, which might be contributing to this issue.

In the meantime, if there are any interim recommendations or workarounds you could suggest—especially for handling getCurrent returning null in mColors—we’d appreciate it. We’ll also continue reviewing the commit history to see if there’s any further context.

Thanks again for your help!