Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Notch and corners #112

Open
j2g2rp opened this issue Oct 25, 2021 · 2 comments
Open

Support for Notch and corners #112

j2g2rp opened this issue Oct 25, 2021 · 2 comments
Labels
enhancement New feature or request mimameid This issue was observed on the Volla Phone 22 (2022) upstream This issue isn't specific to the Volla Phone port yggdrasil This issue was observed on the Volla Phone (2020) yggdrasilx This issue was observed on the Volla Phone X (2021)

Comments

@j2g2rp
Copy link

j2g2rp commented Oct 25, 2021

Using Vollaphone X: By default corners hide part of the indicator or the windows. Same problem with notch.
I tried to use the patch https://github.com/JamiKettunen/unity8-notch-hax following the steps but after command:
./apply-notch-hax.sh
The patch don't manage to recognice the device.
I also tried putting the code name ygddrasilx (and with ygddrasil) In both cases returned that patch is not found.
So I edited manually the files followint the file:
https://github.com/JamiKettunen/unity8-notch-hax/blob/main/patches/yggdrasil.diff
The result it is better but IMHO It would be better with further changes. For example, it would be nice if the unity bar had more margin to advoid the notch to hide the icons. It also could be a problem for some apps on landscape mode.
Anyway, thanks to @JamiKettunen for the patch. It is really usefull.

@wurzer wurzer added the enhancement New feature or request label Jun 28, 2022
@JamiKettunen JamiKettunen added yggdrasil This issue was observed on the Volla Phone (2020) yggdrasilx This issue was observed on the Volla Phone X (2021) mimameid This issue was observed on the Volla Phone 22 (2022) labels Jul 8, 2022
@JamiKettunen
Copy link
Collaborator

ubports/unity8#442 should be of value to (partially?) fix this once it's merged.
@j2g2rp I finally got back to that notch-hax repo a week ago and now Volla Phone X should be supported out of the box as well.

@JamiKettunen JamiKettunen added the upstream This issue isn't specific to the Volla Phone port label Jul 9, 2022
@j2g2rp
Copy link
Author

j2g2rp commented Jul 14, 2022

ubports/unity8#442 should be of value to (partially?) fix this once it's merged. @j2g2rp I finally got back to that notch-hax repo a week ago and now Volla Phone X should be supported out of the box as well.

@JamiKettunen Thanks for update the patch. It works fine now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mimameid This issue was observed on the Volla Phone 22 (2022) upstream This issue isn't specific to the Volla Phone port yggdrasil This issue was observed on the Volla Phone (2020) yggdrasilx This issue was observed on the Volla Phone X (2021)
Projects
None yet
Development

No branches or pull requests

3 participants