Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deploying #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Deploying #63

wants to merge 2 commits into from

Conversation

dreamgonfly
Copy link
Contributor

Pull Request

레파지토리에 기여해주셔서 감사드립니다.

해당 PR을 제출하기 전에 아래 사항이 완료되었는지 확인 부탁드립니다:

  • [v] 작성한 코드가 어떤 에러나 경고없이 빌드가 되었나요?
  • [v] 충분한 테스트를 수행하셨나요?
    => GitHub action 제외하고는 테스트하였습니다. GitHub action은 로컬에서 테스트가 어렵습니다.

1. 해당 PR은 어떤 내용인가요?

서빙 & 배포

2. PR과 관련된 이슈가 있나요?

#62

@dreamgonfly dreamgonfly requested a review from ssaru October 10, 2020 06:51
@dreamgonfly dreamgonfly self-assigned this Oct 10, 2020
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #63 into master will increase coverage by 15.53%.
The diff coverage is 97.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #63       +/-   ##
===========================================
+ Coverage   63.41%   78.94%   +15.53%     
===========================================
  Files           6       10        +4     
  Lines          41       76       +35     
===========================================
+ Hits           26       60       +34     
- Misses         15       16        +1     
Flag Coverage Δ
#tests 78.94% <97.14%> (+15.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
serving/app_factory.py 91.66% <91.66%> (ø)
predictor.py 100.00% <100.00%> (ø)
server.py 100.00% <100.00%> (ø)
tests/test_server.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929c2d2...2b0021c. Read the comment docs.

Copy link
Member

@ssaru ssaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants