-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tx data lake] Filter out specific transaction type #70
Comments
From my perspective, this has high priority. Without this feature, we are not able to query any fields, that are not shared by every transaction type. I have taken a look of how we could add it, and I think the TxInBlock datalake would be the place to do it. One thing to keep in mind, that that solidity defaults to |
One idea, this filter type should be also exist in datalake definition ( meaning also when we encode/commit this type specification should be effect as well ) ,would like to suggest have
we sum up the value that we want to filter to the
|
plus, if we fix on working on this, good to handle #72 together as this will also introduce encode/commit changes |
updated suggestion:
pub struct TransactionsInBlockDatalake {
// target block number
pub target_block: u64,
// ex. "tx.to" , "tx.gas_price" or "tx_receipt.success", "tx_receipt.cumulative_gas_used"
pub sampled_property: TransactionsCollection,
// start index of transactions range ( default 0 )
pub start_index: u64,
// start index of transactions range ( default last )
pub end_index: u64,
// increment of transactions
pub increment: u64,
// filter out the specific type of Txs
pub included_types: u64
} And in And in Cairo can decode included_types, u64 type -> binary representation and loop through the bits |
close as #66 |
There are different eips introduced different transaction type that holds different fields to decode from. By default we get all the types within the range, but ideally user should have flexibility to filter the specific transaction types.
The text was updated successfully, but these errors were encountered: