Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup primitives #147

Merged
merged 5 commits into from
Sep 15, 2024
Merged

chore: cleanup primitives #147

merged 5 commits into from
Sep 15, 2024

Conversation

rkdud007
Copy link
Member

make primitives more idiomatic

  • follow conversion with standard trait like From Into , try to avoid non-standard method
  • looking carefully on usage of unwrap. modify method if unwrap is not needed ( especially primitives ) and write proper documentation for panic condition

@rkdud007 rkdud007 merged commit 4ccd4f5 into dev Sep 15, 2024
3 checks passed
@rkdud007 rkdud007 deleted the refactor/trait branch September 15, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rkdud007