Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIR + OODS #14

Merged
merged 13 commits into from
Jan 3, 2024
Merged

AIR + OODS #14

merged 13 commits into from
Jan 3, 2024

Conversation

tiagofneto
Copy link
Contributor

Closes #5

@tiagofneto tiagofneto self-assigned this Dec 19, 2023
@tiagofneto
Copy link
Contributor Author

  • No testing for now as the reference cairo0 implementation doesn't have tests implemented for this. We will have to verify various proofs, printing values in the middle of the execution and write our own tests based on this
  • Overloaded basic math operators for felt252 by converting the inputs to u256, applying the operation and converting the result back to felt252. I'm not sure if this is the best approach

@tiagofneto tiagofneto marked this pull request as ready for review December 29, 2023 16:53
Okm165
Okm165 reviewed Jan 2, 2024
View reviewed changes
src/air/autogenerated.cairo Outdated Show resolved Hide resolved
Okm165
Okm165 reviewed Jan 2, 2024
View reviewed changes
src/oods.cairo Show resolved Hide resolved
Okm165
Okm165 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@Okm165 Okm165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we have other task for refactoring folder structure for other layouts i approve the pull request

fmkra
fmkra reviewed Jan 3, 2024
View reviewed changes
src/air/composition.cairo Outdated Show resolved Hide resolved
src/air/composition.cairo Outdated Show resolved Hide resolved
fmkra
fmkra approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@fmkra fmkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tiagofneto tiagofneto merged commit c706be7 into main Jan 3, 2024
2 checks passed
@tiagofneto tiagofneto deleted the feat/oods branch January 3, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okm165 Okm165 Okm165 approved these changes

@fmkra fmkra fmkra approved these changes

Assignees

@tiagofneto tiagofneto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIR + OODS constitency check (DEEP)
3 participants
@tiagofneto @fmkra @Okm165