Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for the overflow problem on screens with viewport width of 360px and below #28

Merged

Conversation

bilelBoulhia
Copy link
Contributor

issue link : #27

to fix the problem :

  1. changed main display to flex for more responsiveness and made the overflow hidden
  2. removed hardcoded sizes for the feature image and changed it to 100%
  3. added inline padding for the section title .
    (note : i installed markdoc dependency and then removed it )

I have put a comment under each change to make them clear

@bilelBoulhia
Copy link
Contributor Author

@flavioislima can you please check this PR please (if you have the time for it of course)

@flavioislima
Copy link
Member

Thanks for fixing the issue. Can you add the .idea folder to .gitignore as well?

@bilelBoulhia
Copy link
Contributor Author

bilelBoulhia commented Oct 15, 2024

Thanks for fixing the issue. Can you add the .idea folder to .gitignore as well?

@flavioislima , sorry for the late reply , it is done.

package-lock.json Outdated Show resolved Hide resolved
pages/index.tsx Outdated Show resolved Hide resolved
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.
Code looks good now.

@flavioislima flavioislima merged commit 38256ef into Heroic-Games-Launcher:main Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants