Change service config block to TypeList with MaxItems of 1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the Terraform SDK doesn't support the use of TypeSet with elements that have nested configuration blocks: hashicorp/terraform-plugin-sdk#616 The workaround is to instead use a TypeList with a MaxItems of 1. We've changed convertToTypeSet to convertToTypeList and made this change. We've also had to modify client.GetServiceSettingsMap to expect a []interface{} as opposed to *schema.TypeSet We've added a TODO about this so that when the SDK supports nested resources in TypeSet then we can revert to TypeSet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Terraform SDK doesn't support the use of TypeSet with
elements that have nested configuration blocks:
hashicorp/terraform-plugin-sdk#616
The workaround is to instead use a TypeList with a MaxItems of 1. We've
changed convertToTypeSet to convertToTypeList and made this change.
We've also had to modify client.GetServiceSettingsMap to expect a
[]interface{} as opposed to *schema.TypeSet
We've added a TODO about this so that when the SDK supports nested
resources in TypeSet then we can revert to TypeSet.