feat: handling multilines results with custom output handler #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have pushed a couple of commits of my own. A couple of notes:
I think it should be good now. If you want you can squash the commits into one, then I can merge the PR. |
Lazily `require` JSON module in output handler We `require` the output handler in Neovim in order to get the full path to its source. This executes all top-level statements of the handler, including any `require` calls. If one of the required modules is not installed (in this case `dkjson`) an error is raised. The solution is to move the `require` call into the function call of the module. The module will not be called by Neovim, but by busted, and the dkjson module will be present in that context. Add commentary (motivation) to output handler Undo stylistic changes Shorten name of `output_handler_path` variable Makes it easier to read. Search for last result line containing the marker Rename marker variable The variable is already scoped to the output handler, so the name can be something short. Add tests which write to standard output These tests are meant to be run from within Neovim. Add test for when output contains result marker This is why it is important to search for the output marker backwards.
|
Sounds cool. No experience with this squash you suggested. Hope done it right. |
Closed
|
Yes, you have squashed everything correctly. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the multiline problem by creating a custom output handler that prepends the json output with a marker.