-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to PacketEvents (depends on https://github.com/HibiscusMC/HibiscusCommons/pull/12) #153
Open
OakLoaf
wants to merge
21
commits into
HibiscusMC:remapped
Choose a base branch
from
OakLoaf:remapped
base: remapped
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into remapped # Conflicts: # build.gradle.kts # common/src/main/java/com/hibiscusmc/hmccosmetics/listener/PlayerGameListener.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select the option(s) that best describes this PR:
Please describe the changes this PR makes and why it should be merged:
Check that:
JavaDocs
This PR focuses on moving over to PacketEvents from ProtocolLib, I've given more detail about reasons for changes in the HibiscusCommons PR, of which this PR depends on.
This PR could contain breaking changes for dependencies, although the methods/classes that have been deleted in this PR all appear to be intended for internal use. Unfortunately, keeping the methods/classes wasn't particularly a possibility without creating some form of packet converter which would've been a large amount of work for what is likely to be unused outside of the project.
It is important to note that this PR has only been tested on 1.21.1 so testing is very much needed.