Migration to PacketEvents #12
Conversation
# Conflicts: # build.gradle.kts # common/src/main/java/me/lojosho/hibiscuscommons/nms/NMSHandler.java # common/src/main/java/me/lojosho/hibiscuscommons/util/packets/PacketManager.java # v1_19_R3/src/main/java/me/lojosho/hibiscuscommons/nms/v1_19_R3/NMSHandler.java # v1_20_R1/src/main/java/me/lojosho/hibiscuscommons/nms/v1_20_R1/NMSHandler.java # v1_20_R2/src/main/java/me/lojosho/hibiscuscommons/nms/v1_20_R2/NMSHandler.java # v1_20_R3/src/main/java/me/lojosho/hibiscuscommons/nms/v1_20_R3/NMSHandler.java # v1_20_R4/src/main/java/me/lojosho/hibiscuscommons/nms/v1_20_R4/NMSHandler.java # v1_21_R1/src/main/java/me/lojosho/hibiscuscommons/nms/v1_21_R1/NMSHandler.java
# Conflicts: # build.gradle.kts # common/src/main/java/me/lojosho/hibiscuscommons/util/packets/PacketManager.java
|
I will be opening a PR in the HMCCosmetics repo to update it inline with these changes but that's the only dependency I have personally updated. |
|
I do appreciate such a feature pack PR, however, this is not the direction that we are going to take HibiscusCommons. While ProtocolLib has its issues, I have had a bad history of using PacketEvents (hence why we run ProtocolLib now since HMCC 2.x). We are pushing towards moving entirely towards NMS rather than relying on a single library to handle all the packets. If you want to talk more about it, feel free to send me a message on the Discord server :) |
|
That's perfectly fine! I'll continue to maintain the fork for personal use nonetheless. PacketEvents definitely has some complexities to it, but the support server is active and resolves that for me personally. |
My goal for this fork in general was to remove as much version specific code as possible and migrate to PacketEvents, which is, from my experience, a more maintained, performant and generally easier to use alternative to ProtocolLib.
I've been maintaining this fork for a little while for personal use but avoided making a PR as I thought it might be unwanted, hence the relatively long timespan seen in the commit history.
I have tried to make all API changes backwards compatible and marked old methods as deprecated, instead of just opting for removal. Although, I will note that this may not have always been the case and some methods may no longer be present.
It is important to note that this PR has only been tested on 1.21.1 so testing is very much needed.