Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code and add Composer #12

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Firesphere
Copy link

@Firesphere Firesphere commented Jul 12, 2021

  • Refactored code to PSR-2 standards
  • Simplified code where possible
  • Removed unused constructors
  • Added require_once for all letters
  • Added "get words for letter" function
  • Added example php file
  • Renamed lib to src (use of src is more common than lib)
  • Added composer.json for packagist.org
  • Changed letter classes to have a static array instead of a method
  • Added docblocks
  • Changed quotation to " quotes, for easier wording ("yogurt's" versus 'yogurt\'s')
  • Aligned arrows of language arrays (This is a personal preference, not a guide or PSR standard)
  • Added "count for letter" method
  • Added way to get American and British spellings for words starting with a letter separately
  • ONLY Supports PHP7.1 (return types etc.)
  • Added generated docs from PHP Docblocks

note
Some changes to md files are due to auto formatting. They don't affect the actual output, only readability.

@Firesphere Firesphere marked this pull request as ready for review July 12, 2021 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant