Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttle does not work for llama.cpp #18293

Open
2 of 3 tasks
fxcoudert opened this issue Sep 9, 2024 · 2 comments
Open
2 of 3 tasks

Throttle does not work for llama.cpp #18293

fxcoudert opened this issue Sep 9, 2024 · 2 comments
Labels
bug Reproducible Homebrew/brew bug help wanted We want help addressing this

Comments

@fxcoudert
Copy link
Member

fxcoudert commented Sep 9, 2024

brew doctor output

Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some taps are not on the default git origin branch and may not receive
updates. If this is a surprise to you, check out the default branch with:
  git -C $(brew --repo homebrew/core) checkout master

Verification

  • My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
  • I ran brew update twice and am still able to reproduce my issue.
  • This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output

HOMEBREW_VERSION: 4.3.19-113-gfc49faf
ORIGIN: https://github.com/Homebrew/brew
HEAD: fc49faf68366d04162dff5ff373e899304278622
Last commit: 11 hours ago
Core tap HEAD: 7dd39b2074c2a265f5876fac01b7e8dda6a332f7
Core tap last commit: 9 hours ago
Core tap branch: bump-llama.cpp-3707
Core tap JSON: 02 Apr 07:55 UTC
Core cask tap HEAD: f70d37ccb8d9aed963e3edffc78067cb22b9892b
Core cask tap last commit: 10 hours ago
Core cask tap JSON: 02 Apr 07:55 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: /private/tmp/com.apple.launchd.JKesxo5gEP/org.xquartz:0
HOMEBREW_EDITOR: vim
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 8
HOMEBREW_NO_AUTO_UPDATE: set
HOMEBREW_NO_INSTALL_CLEANUP: set
HOMEBREW_NO_INSTALL_FROM_API: set
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.3.4 => /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4_1/bin/ruby
CPU: octa-core 64-bit arm_firestorm_icestorm
Clang: 15.0.0 build 1500
Git: 2.39.3 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 8.7.1 => /usr/bin/curl
macOS: 14.6.1-arm64
CLT: 15.3.0.0.1.1708646388
Xcode: 15.4
Rosetta 2: false

What were you trying to do (and why)?

Trying to throttle the llama.cpp formula in PR Homebrew/homebrew-core#183973 because it ships too many versions per day.

What happened (include all command output)?

With the PR applied, I get:

⏚ [fx:/opt/ … ary/Taps/homebrew/homebrew-core/Formula] bump-llama.cpp-3707 ± brew livecheck llama.cpp
llama.cpp: 3705 ==> 3707

What did you expect to happen?

I would expect the throttling to work, and not propose versions that are not multiples of 5.

Step-by-step reproduction instructions (by running brew commands)

- Apply the PR
- Run `brew livecheck llama.cpp`
@fxcoudert fxcoudert added the bug Reproducible Homebrew/brew bug label Sep 9, 2024
@fxcoudert
Copy link
Member Author

fxcoudert commented Sep 9, 2024

PS: it's about the llama.cpp but I still think it's a generic brew bug, probably failure to correctly parse its versioning scheme? It could happen for other formulas, although I have no example at the moment.

@MikeMcQuaid MikeMcQuaid added the help wanted We want help addressing this label Sep 9, 2024
@Bo98
Copy link
Member

Bo98 commented Sep 9, 2024

Throttling major versions is not currently supported. Only patch versions.

A possible solution is instead of throttling the patch version we throttle the "last component", but this might incorrectly handle projects that use X.Y.Z but omit Z on .0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Reproducible Homebrew/brew bug help wanted We want help addressing this
Projects
None yet
Development

No branches or pull requests

3 participants