cmd/desc: fix handling of --eval-all
with formulae
#16195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Fixes #16188
This was caused by some refactoring of
Formula.all
a few months ago.In this case,
--eval-all
was not propagated to theFormula.all
command which caused a few different description related commands not to work.Broken commands:
brew search --desc --eval-all TERM
brew desc --search --eval-all TERM
brew desc --descriptions --eval-all TERM
These commands will fail if the cache store has not already been built locally since this specific method call is only needed when building the cache store not accessing it. The cache store file can be found at:
"$(brew --cache)/descriptions.json"
Before:
After these changes, the file should be created and the commands should work as expected.