Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update.sh: fix unused environment variable #18825

Merged
merged 1 commit into from
Nov 26, 2024
Merged

update.sh: fix unused environment variable #18825

merged 1 commit into from
Nov 26, 2024

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

HOMEBREW_UPDATE_CLEANUP was added to this file in 2016 but wasn't ever a recognized environment variable. Not sure if this is the best fix, though.

jekkyll76
jekkyll76 reviewed Nov 26, 2024
View reviewed changes
Copy link

@jekkyll76 jekkyll76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update

Library/Homebrew/cmd/update.sh Show resolved Hide resolved
MikeMcQuaid
MikeMcQuaid approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EricFromCanada!

@MikeMcQuaid MikeMcQuaid merged commit ac025e3 into master Nov 26, 2024
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the update-env-var branch November 26, 2024 08:27
carlocab added a commit that referenced this pull request Dec 3, 2024
@carlocab
cmd/update: avoid switching developers to stable branch
4029e3d 
Checking for `HOMEBREW_NO_INSTALL_CLEANUP` was added in #18825, but this
breaks developers by switching them to the stable branch.

Setting `HOMEBREW_NO_UPDATE_CLEANUP` when `HOMEBREW_NO_INSTALL_CLEANUP`
is set seems like a relatively recent addition, so I don't think it
hurts to just remove it. We can add it back (correctly) if there are
users that need it.
@carlocab carlocab mentioned this pull request Dec 3, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jekkyll76 jekkyll76 jekkyll76 left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EricFromCanada @MikeMcQuaid @jekkyll76