Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swi-prolog (GUI) #176803

Closed
wants to merge 1 commit into from
Closed

Add swi-prolog (GUI) #176803

wants to merge 1 commit into from

Conversation

munro
Copy link

@munro munro commented Jun 14, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the [token reference](https://docs.brew.sh/Cask-Cookbook#token-reference).

    There is already a core package named swi-prolog, but as far as I can tell from this document, the cast should also be named swi-prolog (though I originally was calling it swi-prolog-gui).

    To make this work I had remove swi-prolog from tap_migrations.json. I'm thinking this should be safe, as this migration happend on Aug 22, 2016: bf9a703

    I'm thinking a caveat should also be added to core/swi-prolog similar to core/wireshark (I can open a PR for that to!):

    This formula only installs the command-line utilities by default.
    
    Install Wireshark.app with Homebrew Cask:
      brew install --cask wireshark
    
  • Checked the cask was not already refused (add your cask's name to the end of the search field).

  • Checked the cask is submitted to the correct repo.

  • brew audit --cask --new swi-prolog worked successfully.

    I get two errors:

    audit for swi-prolog: failed
    - Signature verification failed:
    /private/tmp/cask-audit20240614-43570-3g36p6/SWI-Prolog.app: rejected
    
    macOS on ARM requires software to be signed.
    Please contact the upstream developer to let them know they should sign and notarize their software.
    
    - possible duplicate, cask token conflicts with Homebrew core formula: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/s/swi-prolog.rb
    swi-prolog
    * line 5, col 2: Signature verification failed:
        /private/tmp/cask-audit20240614-43570-3g36p6/SWI-Prolog.app: rejected
    
        macOS on ARM requires software to be signed.
        Please contact the upstream developer to let them know they should sign and notarize their software.
    * possible duplicate, cask token conflicts with Homebrew core formula: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/s/swi-prolog.rb
    Error: 2 problems in 1 cask detected.
    

    I'm not sure what to do about the unsigned issue, it is from the offical swi-prolog site though! Maybe open an issue for them to get it signed?

    And for the name conflict, it seems like I should name it as swi-prolog the same as wireshark.

  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask swi-prolog worked successfully.

  • brew uninstall --cask swi-prolog worked successfully.

  • brew livecheck --cask swi-prolog worked successfully.


Hello all! The reason I'm adding this is the swi-prolog formula doesn't have GUI support! So you can't use the graphical debugger gtrace. (it's very nice!)

There are some issues though (commented about), that I would love help resolving:

  • It should be named swi-prolog even though there is a formula swi-prolog? Or should it be something like swi-prolog? Currently audit is giving a duplicate name error. 😢
  • It's ok to remove from tap_migrations.json?
  • Need help, the official binary from SWI Prolog is unsigned.

Thanks y'all!

@miccal
Copy link
Member

miccal commented Jun 14, 2024

Thank you for your submission @munro, but we cannot accept it at this time because it does not pass our signature verification check that is a requirement for new submissions:

macOS on ARM requires software to be signed. Please contact the upstream developer to let them know they should sign and notarize their software.

Please consider hosting this in your own Tap and if the developers sign their app in the future we would then be happy to consider adding this to homebrew-cask.

@munro
Copy link
Author

munro commented Jun 14, 2024

@miccal thank you! Hopefully the package can be signed, opened up an issue to see if the devs can make it happen: SWI-Prolog/swipl-devel#1288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants